Quote from: Netscape1964 on Jul 28, 2023, 03:20 PMsince you are on linux, it should be easier to make a mirror folder for the girls folder which, lets face it, is usually the biggest of the game folders. that way you can run the main files from diskdrive to see if it's still jumpy. you can see that way if it's your use stick the problem or the game engine

Actually, I'm on Linux too at the moment (my other laptop is Windows only). The way I use the girls is so that I have a separate folder named BrothelKingGirls for all the girls and girlpacks I'm using, alongside the Brothel_King-pc one. This folder is then symlinked as game/girls into all Brothel King installations (regardless of version). This setup saves a lot of space (my girls are 12GB in size).

@Goldo, just an idea: could we get an option to set up the path to girls on all the systems? Girl folders are read-only, so it should be possible. There can be some mess if version-specific features are used, but you don't have to bother with it, burden the player with the issues. Simply create a variable which can be overridden by some .ini file, set up the "game/girls" folder as a default value, and never document the variable outside of code; this way most players won't even notice the feature, and if one does, you can assume (s)he is knowledgeable enough to be able to pick the pieces themselves once something breaks.

Quote from: Hermenegild on Jul 28, 2023, 03:35 PMActually, I'm on Linux too at the moment (my other laptop is Windows only). The way I use the girls is so that I have a separate folder named BrothelKingGirls for all the girls and girlpacks I'm using, alongside the Brothel_King-pc one. This folder is then symlinked as game/girls into all Brothel King installations (regardless of version). This setup saves a lot of space (my girls are 12GB in size).

good trick.
symlinks should also work the same for windows users 

Quote from: AnalogSquirrel on Jul 28, 2023, 02:54 PMIs there something that can be done about performance with respect to mouse-over items?

Granted, I'm running the game on an old linux laptop, through a USB stick (girl packs were taking up too much space on the hard driver, so I gave the game its own space), so I'm not really set up for speed...

Anyway, whenever I mouse-over one of the items with the tool tips, the whole game gets real "jumpy" - it's hard to use the mouse to navigate that way.

I suspect this may be a renpy thing, and there isn't too much you can do about it, but if you could figure out how to smooth it out, it'd be a big improvement.

Oh, one other thing - I just had a girl come up who is both Sane and Insane at the same time.  It isn't game-breaking (they basically offset each other), but I'm not sure it's intentional, either.

Just saw your message, one thing you can do is look for line 630 in BKitems.rpy:
tooltip it.descriptionand comment it out or delete it.

But it's unlikely to be the only issue you encounter running the game from a USB stick.
And it's kind of surprising that a static tooltip would give you that much trouble, so it may be Ren'py predicting the next screen that's slowing you down - in which case it'll be harder to fix.

By the way, I believe this variable in options.rpy is the culprit for 0.3 receiving persistent information from 0.2:
python early:
    config.save_directory = "Bro King-1419249291"
Warning: I haven't tested changing this. If you change it, let me know how it goes.

Quote from: Goldo on Jul 28, 2023, 03:41 PMJust saw your message, one thing you can do is look for line 630 in BKitems.rpy:

Code Select Expand

tooltip it.descriptionand comment it out or delete it.

But it's unlikely to be the only issue you encounter running the game from a USB stick.
And it's kind of surprising that a static tooltip would give you that much trouble, so it may be Ren'py predicting the next screen that's slowing you down - in which case it'll be harder to fix.

I've tried the symlink trick, and it does seem to have improved things.  I'll try the tooltip line next.  It seems weird that simply displaying a tooltip would require so much from File/IO system.

Also also managed to nuke about half of my girl folders.  Remember to be careful with rm -rf kids 

Quote from: AnalogSquirrel on Jul 28, 2023, 05:23 PMAlso also managed to nuke about half of my girl folders.  Remember to be careful with rm -rf kids 

True ;-) But this is actually another moment where the symlink trick saves you: without additional options, "rm -rf" does not follow symbolic links, just removes them, so you remove your game folder but not your girls.

Got this after using a card: (It can be ignored)

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKmain.rpy", line 559, in script call
    call farm_powers() from _call_farm_powers
  File "game/BKpowers.rpy", line 474, in script
    $ spent_mojo = evpower_deck.play(selected_power, conduct)
  File "game/BKpowers.rpy", line 474, in <module>
    $ spent_mojo = evpower_deck.play(selected_power, conduct)
  File "game/BKpowers.rpy", line 285, in play
    return MC.spend_mojo(power.get_mojo_cost(conduct))
  File "game/BKclasses.rpy", line 448, in spend_mojo
    if not self.has_mojo(cost_list, use_purple=use_purple, mod=mod):
NameError: name 'mod' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKmain.rpy", line 559, in script call
    call farm_powers() from _call_farm_powers
  File "game/BKpowers.rpy", line 474, in script
    $ spent_mojo = evpower_deck.play(selected_power, conduct)
  File "C:\Users\Dani\Downloads\Brothel_King-0.3t\Brothel_King-pc\renpy\ast.py", line 1138, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Users\Dani\Downloads\Brothel_King-0.3t\Brothel_King-pc\renpy\python.py", line 1122, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKpowers.rpy", line 474, in <module>
    $ spent_mojo = evpower_deck.play(selected_power, conduct)
  File "game/BKpowers.rpy", line 285, in play
    return MC.spend_mojo(power.get_mojo_cost(conduct))
  File "game/BKclasses.rpy", line 448, in spend_mojo
    if not self.has_mojo(cost_list, use_purple=use_purple, mod=mod):
NameError: name 'mod' is not defined

Windows-10-10.0.19045 AMD64
Ren'Py 8.1.1.23060707
Brothel King 0.3t v230721
Sat Jul 29 05:16:28 2023


Quote from: Deimos96 on Jul 28, 2023, 07:37 AMThe way sex stats are displayed when they get a bonus from traits seems odd. Her sex stat should be 20 but is displayed as 40. Note that the sex stat gains come from a trait from the Trait King mod.

DISCLAIMER:  I have Trait King v21 installed.  Using a post by Deimos96 here as he has the perfect screenshot for visuals and I am too lazy to create my own   Have not been able to replicate Deimos96's issue so far, but will update if I can replicate.

More of a feedback post than anything.

I think that when the cursor hovers over a trait that gives a boost or detriment to skills like Service or Sex or to a stat like Charm or Beauty, the green/red bar should illuminate.  To use the example in the screenshot, when the player hovers over "Fake Orgasms", the green bar should illuminate with the bonus provided.

Current behavior does not do this.  In fact, the bar only illuminates when the cursor hovers over any skill or stat bar to get the tooltip about what it does and what it affects.  It does not have to be the stat or skill bar in question.

I downloaded the game and the latest patch today.
The game exited after I visited the save screen, got this from the traceback.txt

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "renpy/common/00start.rpy", line 310, in script call
    call expression "before_main_menu"
  File "game/BKevents.rpy", line 66, in script
    $ update_mods()
  File "game/BKevents.rpy", line 66, in <module>
    $ update_mods()
  File "game/BKfunctions.rpy", line 3803, in update_mods
    for name, d in persistent.mods.items():
RuntimeError: dictionary changed size during iteration

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "renpy/common/00start.rpy", line 310, in script call
    call expression "before_main_menu"
  File "game/BKevents.rpy", line 66, in script
    $ update_mods()
  File "D:\Games\Brothel_King-pc\renpy\ast.py", line 1138, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "D:\Games\Brothel_King-pc\renpy\python.py", line 1122, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKevents.rpy", line 66, in <module>
    $ update_mods()
  File "game/BKfunctions.rpy", line 3803, in update_mods
    for name, d in persistent.mods.items():
RuntimeError: dictionary changed size during iteration

Windows-10-10.0.19045 AMD64
Ren'Py 8.1.1.23060707
Brothel King 0.3t v230721
Sat Jul 29 23:20:51 2023

So I'm getting this error every so often when I get to the Farm scenes. I more or less downloaded the patch either today.

[code]
I'm sorry, but an uncaught exception occurred.

While processing the color property of anonymous style:
  File "game/BKendday.rpy", line 1122, in script call
    call show_night_event(ev) from _call_show_night_event_1
  File "game/BKevents.rpy", line 775, in script
    $ renpy.say(ev.char, text_descript + "{/size}")
  File "game/BKevents.rpy", line 775, in <module>
    $ renpy.say(ev.char, text_descript + "{/size}")
ValueError: invalid literal for int() with base 16: '=#'

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKendday.rpy", line 1122, in script call
    call show_night_event(ev) from _call_show_night_event_1
  File "game/BKevents.rpy", line 775, in script
    $ renpy.say(ev.char, text_descript + "{/size}")
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\ast.py", line 1138, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\python.py", line 1122, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKevents.rpy", line 775, in <module>
    $ renpy.say(ev.char, text_descript + "{/size}")
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\exports.py", line 1473, in say
    who(what, *args, **kwargs)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\character.py", line 1352, in __call__
    self.do_display(who, what, cb_args=self.cb_args, dtt=dtt, **display_args)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\character.py", line 1003, in do_display
    display_say(who,
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\character.py", line 693, in display_say
    rv = renpy.ui.interact(mouse='say', type=type, roll_forward=roll_forward)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\ui.py", line 299, in interact
    rv = renpy.game.interface.interact(roll_forward=roll_forward, **kwargs)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 3579, in interact
    repeat, rv = self.interact_core(preloads=preloads, trans_pause=trans_pause, pause=pause, pause_start=pause_start, pause_modal=pause_modal, **kwargs) # type: ignore
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 4052, in interact_core
    root_widget.visit_all(lambda d : d.per_interact())
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 681, in visit_all
    d.visit_all(callback, seen)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 681, in visit_all
    d.visit_all(callback, seen)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 681, in visit_all
    d.visit_all(callback, seen)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\screen.py", line 481, in visit_all
    self.child.visit_all(callback, seen=None)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 681, in visit_all
    d.visit_all(callback, seen)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 681, in visit_all
    d.visit_all(callback, seen)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 681, in visit_all
    d.visit_all(callback, seen)
  [Previous line repeated 5 more times]
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 683, in visit_all
    callback(self)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\display\core.py", line 4052, in <lambda>
    root_widget.visit_all(lambda d : d.per_interact())
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\text\text.py", line 1792, in per_interact
    if self.style.slow_abortable:
  File "gen3-static/styleclass.pxi", line 533, in renpy.styledata.styleclass.Style.slow_abortable.__get__
  File "style.pyx", line 493, in renpy.style.StyleCore._get
  File "style.pyx", line 710, in renpy.style.build_style
  File "style.pyx", line 707, in renpy.style.build_style
  File "gen3-static/style_functions.pyx", line 323, in style_functions.color_property
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\color.py", line 147, in __new__
    r = int(c[0]+c[1], 16)
ValueError: invalid literal for int() with base 16: '=#'

Windows-10-10.0.19045 AMD64
Ren'Py 8.1.1.23060707
Brothel King 0.3t v230721
Sat Jul 29 15:49:10 2023

[/code]

Welp just found another error.  This time I just finished the first ninja minigame.  I went after the water one.  Also I guess I should mention I'm using the widescreen option for the game.

[code]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKmain.rpy", line 305, in script call
    call ninja_hunt(selected_location) from _call_ninja_hunt
  File "game/BKchapter2.rpy", line 5361, in script call
    call ninja_game(NPC_mizuki) from _call_ninja_game_1
  File "game/BKminigame.rpy", line 230, in script call
    call ninja_intercept(ninja, njgame.special) from _call_ninja_intercept_1
  File "game/BKchapter2.rpy", line 5546, in script
    $ shuffle_ninja_location(ninja)
  File "game/BKchapter2.rpy", line 5546, in <module>
    $ shuffle_ninja_location(ninja)
  File "game/BKminigame.rpy", line 18, in shuffle_ninja_location
    ninja.used_loc.append(ninja.loc)
AttributeError: 'NPC' object has no attribute 'used_loc'

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKmain.rpy", line 305, in script call
    call ninja_hunt(selected_location) from _call_ninja_hunt
  File "game/BKchapter2.rpy", line 5361, in script call
    call ninja_game(NPC_mizuki) from _call_ninja_game_1
  File "game/BKminigame.rpy", line 230, in script call
    call ninja_intercept(ninja, njgame.special) from _call_ninja_intercept_1
  File "game/BKchapter2.rpy", line 5546, in script
    $ shuffle_ninja_location(ninja)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\ast.py", line 1138, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "E:\Skyrim\Brothel_King-0.3t\Brothel_King-pc\renpy\python.py", line 1122, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKchapter2.rpy", line 5546, in <module>
    $ shuffle_ninja_location(ninja)
  File "game/BKminigame.rpy", line 18, in shuffle_ninja_location
    ninja.used_loc.append(ninja.loc)
AttributeError: 'NPC' object has no attribute 'used_loc'

Windows-10-10.0.19045 AMD64
Ren'Py 8.1.1.23060707
Brothel King 0.3t v230721
Sat Jul 29 15:58:22 2023

[/code]

Just picked up a bugged(?) girl from the market.  She is level 2 but has -1 perk points to spend.  I also cannot level her up despite having the button and proper indicating icons to do so.

UPDATE:  Now that the girl is leveled up to level 3, I was able to spend only the +10 points going from level 2 to 3, but here perk points are at 0 now having gone from -1 to 0.

EDIT:  Wanted to add additional information in case it mattered or for replication:
girl was bought in year 1 month 2
still in slums location
girl was 3rd total girl
brothel room was bought at same time as girl


DISCLAIMER:  I do have the Trait King v21 mod installed.  It should not affect leveling though.  Just informing for transparency.


Another minor issue I noticed, unrelated to the above, the player's spellbook seems to not have the options aligned properly so they are off-center and are blocking some instruction text and almost the entirety of the back button.  If the player does not know about right-clicking to go backwards in the menus, they may get trapped in the spellbook.

that becasue i beleive the level up button unlocks when it's different from 0 not if it's strictly under 1 so -1 not being 0 it unlocks the level up routines despite not being eligible to a "level up"

Quote from: Goldo on Jul 28, 2023, 03:59 PMBy the way, I believe this variable in options.rpy is the culprit for 0.3 receiving persistent information from 0.2:

Code Select Expand

python early:
    config.save_directory = "Bro King-1419249291"
Warning: I haven't tested changing this. If you change it, let me know how it goes.

I changed it to 696969696 and didnt get any popups or messages and it successfully created a new save folder

New hotfix out:
https://www.mediafire.com/file/1va1v7cq1psp53x/game+patch+0.3.zip/file

Warning: This changes config save_directory to a different dir to avoid conflicts with 0.2 persistent data. If for some reason, you don't want that, you should revert to the old line in game/options.rpy:
config.save_directory = "Bro King-1419249291"(The first two digits have changed).

---

Quote from: 22ndgentlemen on Jul 29, 2023, 06:49 PMDISCLAIMER:  I have Trait King v21 installed.  Using a post by Deimos96 here as he has the perfect screenshot for visuals and I am too lazy to create my own   Have not been able to replicate Deimos96's issue so far, but will update if I can replicate.

Hopefully you won't be able to replicate, since this issue has been fixed.

QuoteMore of a feedback post than anything.

I think that when the cursor hovers over a trait that gives a boost or detriment to skills like Service or Sex or to a stat like Charm or Beauty, the green/red bar should illuminate.  To use the example in the screenshot, when the player hovers over "Fake Orgasms", the green bar should illuminate with the bonus provided.

Current behavior does not do this.  In fact, the bar only illuminates when the cursor hovers over any skill or stat bar to get the tooltip about what it does and what it affects.  It does not have to be the stat or skill bar in question.

Unfortunately it's not possible for now. I can't make sense of the way Ren'py deals with hover_alpha: as you can see while hovering, the '+10' text or whatever shows up properly when hovering over a given bonus bar, but the corresponding alpha setting for the bar doesn't work as expected (hovering over any bar lights up all of them). Giving them different ids doesn't solve the problem.

All of my tests have failed to fix this issue, and there are other screens where hover_alpha acts up. Either it is a bug within Ren'py, or there is some fundamental screen logic that I am missing here.

Quote from: LostInSmut on Jul 29, 2023, 09:49 PMI downloaded the game and the latest patch today.
The game exited after I visited the save screen, got this from the traceback.txt

[...]

This is a known issue due to the aforementioned persistent data. Try a new game with the new patch or follow the workarounds others have posted before.

Quote from: 22ndgentlemen on Jul 30, 2023, 12:03 PMJust picked up a bugged(?) girl from the market.  She is level 2 but has -1 perk points to spend.  I also cannot level her up despite having the button and proper indicating icons to do so.

UPDATE:  Now that the girl is leveled up to level 3, I was able to spend only the +10 points going from level 2 to 3, but here perk points are at 0 now having gone from -1 to 0.

EDIT:  Wanted to add additional information in case it mattered or for replication:
girl was bought in year 1 month 2
still in slums location
girl was 3rd total girl
brothel room was bought at same time as girl


DISCLAIMER:  I do have the Trait King v21 mod installed.  It should not affect leveling though.  Just informing for transparency.

It is most likely related to the mod, having more traits than intended may cause you to unlock extra perk trees and throw off the perk point calculation. I will have to see what kind of sanity check can be added.

Quote from: Iconic9875667 on Jul 30, 2023, 09:17 PM

Quote from: Goldo on Jul 28, 2023, 03:59 PMBy the way, I believe this variable in options.rpy is the culprit for 0.3 receiving persistent information from 0.2:

Code Select Expand

python early:
    config.save_directory = "Bro King-1419249291"
Warning: I haven't tested changing this. If you change it, let me know how it goes.

I changed it to 696969696 and didnt get any popups or messages and it successfully created a new save folder

Thank you for testing this! Also, see what you did there...