News:

Please request registration email again and then check your "Spam" folder

Former www.henthighschool.com

v0.3 Test Version (Aug. 24 Update)

Started by Goldo, Aug 25, 2024, 10:58 PM

Previous topic - Next topic

GoldoTopic starter

Hi guys, here it is finally:
Main download: https://www.mediafire.com/file/svs5ppxr5hellf6/Brothel_King-pc-0.3t.zip/file
Mac version:
Spoiler
https://www.mediafire.com/file/bbtah0i4y7agb94/Brothel_King-mac-0.3t.zip/file
(No idea if this works, I don't have a Mac. Do let me know!)
[close]

Current patch: https://www.mediafire.com/file/1va1v7cq1psp53x/game+patch+0.3.zip/file Apply this on top of the main game files

As usual, you will need to install GIRL PACKS to make it work.



What to expect:
  • Two third of the story from Chapter 3: Learn more about the Earth and Void Kunoichi, and maybe decide their fate.
  • A completely new version of Ren'py (and Python) and a fully redone UI. Graphic glitches from the older versions are gone, but if everything went right you shouldn't notice too many changes.
  • A new 'NewGame+' menu after you reach endless mode.
  • And many more tweaks and changes big and small




Usual disclaimer: This version is for testing and debugging purposes only. There is no guaranty of any kind that it is playable or balanced. It will crash, you will most likely need to start new games regularly, you might lose saved games, and I won't go out of my way to fix your broken saves - so please don't ask me to. You might want to sit this one out, at least for a few days, if you want to avoid the worst of it.



How to report bugs/suggestions (please read before posting!):
  • Only report issues with this specific build, using the latest patch (when available), and on a new game.
  • Please do a minimal search to see if the issue has been reported before posting.
  • Please include a description of how to reproduce the bug as best you can. A saved game is generally unnecessary unless I specifically ask for it.
  • The story of Chapter 3 is not complete, reporting it is unnecessary.
Maker of BK. Looking for the latest patch for BK 0.2? The link doesn't change, so bookmark it!

DarkFire

Got this error after pressing confirm with this set-up:



I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKstart.rpy", line 74, in script call
    call choose_difficulty() from _call_choose_difficulty
  File "game/BKstart.rpy", line 135, in script
    $ commit_start_settings()
  File "game/BKstart.rpy", line 135, in <module>
    $ commit_start_settings()
  File "game/BKfunctions.rpy", line 5118, in commit_start_settings
    MC.learn(Spell(NGP_settings_dict["love generation"].label, 'love_.webp', type="passive", level=1, effects=[Effect("boost", "love gains", NGP_settings_dict["love generation"].get(), scope="brothel")], description="Boosts love gains by %i per cent (NewGame+ effect)." % (100*NGP_settings_dict["love generation"].get())))
  File "game/BKclasses.rpy", line 868, in learn
    self.add_effects(spl.effects)
  File "game/BKclasses.rpy", line 1458, in add_effects
    return add_effects(self, effects, apply_boost=apply_boost, spillover=spillover, expires=expires)
  File "game/BKfunctions.rpy", line 4510, in add_effects
    update_effects(scope_list)
  File "game/BKfunctions.rpy", line 4590, in update_effects
    brothel.effect_dict = defaultdict(list)
NameError: name 'brothel' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKstart.rpy", line 74, in script call
    call choose_difficulty() from _call_choose_difficulty
  File "game/BKstart.rpy", line 135, in script
    $ commit_start_settings()
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.31\Brothel_King-pc\renpy\ast.py", line 823, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.31\Brothel_King-pc\renpy\python.py", line 1178, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKstart.rpy", line 135, in <module>
    $ commit_start_settings()
  File "game/BKfunctions.rpy", line 5118, in commit_start_settings
    MC.learn(Spell(NGP_settings_dict["love generation"].label, 'love_.webp', type="passive", level=1, effects=[Effect("boost", "love gains", NGP_settings_dict["love generation"].get(), scope="brothel")], description="Boosts love gains by %i per cent (NewGame+ effect)." % (100*NGP_settings_dict["love generation"].get())))
  File "game/BKclasses.rpy", line 868, in learn
    self.add_effects(spl.effects)
  File "game/BKclasses.rpy", line 1458, in add_effects
    return add_effects(self, effects, apply_boost=apply_boost, spillover=spillover, expires=expires)
  File "game/BKfunctions.rpy", line 4510, in add_effects
    update_effects(scope_list)
  File "game/BKfunctions.rpy", line 4590, in update_effects
    brothel.effect_dict = defaultdict(list)
NameError: name 'brothel' is not defined

Windows-10-10.0.19045 AMD64
Ren'Py 8.2.0.24012702
Bro King 0.3t v240825
Mon Aug 26 06:10:24 2024

Jman

#2
Well, nice to finally have an update!


There's a new official splashscreen. I like my Chinese contraband version better (a somewhat odd-looking elf staring at a generic isekai city? ??? ), so I guess I'll leave that up for the moment.

There's also an actual program icon now! But why a gold coin? What did Sill do to deserve removal?! :o

I also see that some of the really pixelated item icons have gotten a makeover. :)


A bit of bad news: pushing brothel generation so late in the init messes with things, including the bug report in the previous post, Chris' Job Mod, CJMT, and Trait King.

The move to more recent versions of Ren'Py seems to have made the Augment Mod hiccup due to using no-longer-supported text alignment combinations. Since the mod is pretty much unsupported now, AFAIK, this might need some fixing by whoever hosts that now.


And with strange aeons even death may die...

neronero

#3
NOTE: I am playing with Trait King, don't think these issues are related

Don't know about this one, I got it on the brothel screen while rushing through the game (holding down ctrl)
Unable to replicate it after rolling back, so I can't tell what caused it exactly.
EDIT: Got it again when choosing a perk (slut/bedroom eyes) on one girl, and immediately afterwards choosing a perk (maid/maid training) on another girl.
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKmain.rpy", line 1358, in script call
    call perks() from _call_perks_1
  File "game/BKmain.rpy", line 1607, in script
    $ result, obj = ui.interact() # bj is an archetype or perk
  File "game/BKmain.rpy", line 1607, in <module>
    $ result, obj = ui.interact() # bj is an archetype or perk
TypeError: cannot unpack non-iterable bool object

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKmain.rpy", line 1358, in script call
    call perks() from _call_perks_1
  File "game/BKmain.rpy", line 1607, in script
    $ result, obj = ui.interact() # bj is an archetype or perk
  File "F:\ilx\BK03T20240824\renpy\ast.py", line 823, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "F:\ilx\BK03T20240824\renpy\python.py", line 1178, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKmain.rpy", line 1607, in <module>
    $ result, obj = ui.interact() # bj is an archetype or perk
TypeError: cannot unpack non-iterable bool object

Windows-10-10.0.19045 AMD64
Ren'Py 8.2.0.24012702
Bro King 0.3t v240825
Mon Aug 26 14:46:45 2024



In BKchapter1.rpy, line 6146 shows "image not found" for me
    show maya disarmed flip with dissolve

When visiting a location:
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKmain.rpy", line 295, in script
    $ MC.gain_resource(number=dice(3), random=True)
  File "game/BKmain.rpy", line 295, in <module>
    $ MC.gain_resource(number=dice(3), random=True)
TypeError: gain_resource() got an unexpected keyword argument 'random'

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKmain.rpy", line 295, in script
    $ MC.gain_resource(number=dice(3), random=True)
  File "F:\ilx\BK03T20240824\renpy\ast.py", line 823, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "F:\ilx\BK03T20240824\renpy\python.py", line 1178, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKmain.rpy", line 295, in <module>
    $ MC.gain_resource(number=dice(3), random=True)
TypeError: gain_resource() got an unexpected keyword argument 'random'

Windows-10-10.0.19045 AMD64
Ren'Py 8.2.0.24012702
Bro King 0.3t v240825
Mon Aug 26 14:56:34 2024


My Girl Packs: [ link ] - Trait King mod: [ link ]

Jman

Well, I'm getting this now:
  File "game/Mods/Trait King/Trait King.rpy", line 373, in script
    python:
  File "game/Mods/Trait King/Trait King.rpy", line 1500, in <module>
    refresh_available_locations()
  File "game/BKfunctions.rpy", line 571, in refresh_available_locations
    loc_list = game.get_available_locations()
  File "game/BKclasses.rpy", line 290, in get_available_locations
    if d.rank <= district.rank:
NameError: name 'district' is not defined
Which very much looks like the same thing, except for 'district' instead of 'brothel'.
And with strange aeons even death may die...

neronero

Quote from: Jman on Aug 26, 2024, 01:20 PMWell, I'm getting this now:
  File "game/Mods/Trait King/Trait King.rpy", line 373, in script
    python:
  File "game/Mods/Trait King/Trait King.rpy", line 1500, in <module>
    refresh_available_locations()
  File "game/BKfunctions.rpy", line 571, in refresh_available_locations
    loc_list = game.get_available_locations()
  File "game/BKclasses.rpy", line 290, in get_available_locations
    if d.rank <= district.rank:
NameError: name 'district' is not defined
Which very much looks like the same thing, except for 'district' instead of 'brothel'.
That one's clearly Trait King, I've somewhat fixed it by moving the "Refresh generated girls" operations to a label call that's done on day 1 (just testing to see if everything else still works ok)
My Girl Packs: [ link ] - Trait King mod: [ link ]

Jman

It's still a change that causes modders to find workarounds to fiddle with rather basic game variables and objects. I'd rather have it return to how it was before, rather than forcing every new modder to jump through even more hoops.
And with strange aeons even death may die...

neronero

#7
Not sure if it's accidental. I'll go with whatever's the intention on Goldo's part.

For context @Goldo , Trait King rebuilds the trait_dict so rigorously that afterwards, I want to refresh everything that involves traits: free girls, slaves, quests, effects. That now causes errors if it happens during the mod's init_label. (But that could also mean that these operations aren't needed? edit: After some testing, I'm pretty sure that I don't have to refresh these things anymore now)
We can head to the TK thread if that's a better place for this discussion.

---

A small graphical glitch: When visiting the city and hovering over a visitable district, the first un-visitable location also lights up.
My Girl Packs: [ link ] - Trait King mod: [ link ]

mmm520555

I found that in the post [Girl Pack announcement thread], [The master Google Document of girl packs can be found here.], there are many links to girl packs that are invalid, about 229+69+68=366.
Today I tried to visit them on the Internet again and marked the access situation. Can the author update it and delete the invalid links?

https://mega.nz/file/MI1UXCQD#3fUUaVpIqtOwo_yejXlODwE0D2CDi9tnq17fuI06wZ8

darksythe53

So I do not get an error message but I have noticed that some girls with custom bk.ini files have odd spawning patterns when using custom generate.

generate_as = "all"            # Can be set to 'all' or restricted to 'free', 'slave' or 'story'. Story girls never generate on their own, only during custom events.

If I set the girls to all or slave then they will spawn in the slave market as well as the city, if I set them to free then they never spawn. I have tested by removing all but 10 of my girl packs and then setting once girl to free. Using the cheat menu to unlock all locations, cycle free girls, skip chapter the one girl with free never spawns. I also found one of the girls who was set to slave in the city.

Jman

#10
Have you set 'keep_generate_as' to True as well? Otherwise, the clones will spawn where they want.

I did find that 'can_generate' is somewhat problematic for girls with _BK.ini set to 'unique = True', since they'll always return that they can't generate, and thus they also can't cycle and will therefore be on the free girls list, but fall between the cracks as far as getting to an actual location goes.

Changing can_generate(...) to something like below seems to more or less work, but IDK if there are undesirable second-order effects:
    def can_generate(girl, free=False, context="game", location=None): # Context can be 'game' or 'mix'. Location is an object
        if context == "game":

            if free and location:
                if girl.init_dict["background story/generate_in"] and girl.init_dict["background story/generate_in"] != "all":
                    for place in girl.init_dict["background story/generate_in"]:
                        if location.get_district().name.lower() not in girl.init_dict["background story/generate_in"] and location.name.lower() not in girl.init_dict["background story/generate_in"]:
                            return False
                return True

            # Unique girls may only generate if none other exists
            if girl.init_dict["cloning options/unique"]: # No other girl can generate after the first one
And with strange aeons even death may die...

darksythe53

#11
Quote from: Jman on Aug 26, 2024, 06:15 PMHave you set 'keep_generate_as' to True as well? Otherwise, the clones will spawn where they want.

I did find that 'can_generate' is somewhat problematic for girls with _BK.ini set to 'unique = True', since they'll always return that they can't generate, and thus they also can't cycle and will therefore be on the free girls list, but fall between the cracks as far as getting to an actual location goes.

Follow up on my end. I have keep_generate_as set to true and unique = true on both of the girls set to slave and free. The slave girl is spawning in the market and in town (but not at the same time) and the free girl never spawns. I copy/ pasted the slave girls bk.ini into the free girls folder. Using the copied bk.ini the free girl spawns when set to all or slave but never when set to free. I then deleted and placed back the free girls original bk.ini and got similar results when attempting with all, slave, and free.

Edit: redownloaded bk 0.2 and they both spawn in the proper places with no issue using the same bk.ini files.

Jman

Try modifiying BKfunctions.rpy and add the 'if free and location:' block there as written above. With that, I'm seeing girls set to 'unique' and 'slave'/'free' generate as normal.
And with strange aeons even death may die...

darksythe53

#13
Confirming Jman's fix for my issue works

Edit: New error found when using strength to resolve the hidden door event successfully. When I reach the reward screen I get this then the game continues as normal

Also get a similar screen when using "Look for her cat" to successfully catch the cat except this one says couldn't generate item for rank 0

"Fix the wagon" has the same error as well

GoldoTopic starter

#14
First patch out (link is also in the OP):
https://www.mediafire.com/file/1va1v7cq1psp53x/game+patch+0.3.zip/file

I have moved the mod init lower in the init order, it should happen after brothel and district generation now (hopefully that doesn't cause other problems).

Please note that the patch now includes the root 'game/' folder to dumbproof the patching process.
Maker of BK. Looking for the latest patch for BK 0.2? The link doesn't change, so bookmark it!