[Resources] Headhunter mod

D4EH · Dec 06, 2024, 09:15 AM

I've noticed that whenever im using hh in my current save, game crashes with infinite loop, but in a fresh save, it works fine, in my save I've only unlocked 2nd brothel so im not that far ahead, i thought it was mainly due to potato pc, but while i do have dozens of girls, 55 aint that big of a number, and i had a way bigger number on bk 0.2 with HH and didn't have these issues, and the game and the mod couldn't have possibly changed that much over a couple updates.

Anyways do you have any idea of what i could do to circumvent these issues?, this is the error im getting

Code Select

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1965, in script call
    call make_hhgirl(making_name = get_real_girlpath(hhgirl.path))
  File "game/Mods/Headhunter/Headhunter.rpy", line 2552, in script
    $ g_list = get_girls_hh(1, free = game.headhunter_free, init_dict = input_dict, path = get_real_girlpath(making_name), g_rank = int(headhunted_rank))
Exception: Possible infinite loop.

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1965, in script call
    call make_hhgirl(making_name = get_real_girlpath(hhgirl.path))
  File "game/Mods/Headhunter/Headhunter.rpy", line 2552, in script
    $ g_list = get_girls_hh(1, free = game.headhunter_free, init_dict = input_dict, path = get_real_girlpath(making_name), g_rank = int(headhunted_rank))
  File "C:\Games\F95\Brothel_King-pc\renpy\execution.py", line 61, in check_infinite_loop
    raise Exception("Possible infinite loop.")
Exception: Possible infinite loop.

Also after double checking my version that was "Working" it seems your assumption was right

QuoteOn reflection, perhaps your changes worked because they shortcircuited girl generation by not requiring exact name matches and you were getting offered random gals instead of the one fitting your specifications? That could certainly cut down on looping.

Whatever i may have edited did indeed shortcircuit girl generation, so i was getting random gals, so kinda pointless to use it, since the headhunter cant hunt girls with specific stats or traits lol, weird how that gets rid of the crashes tho

Jman · Dec 06, 2024, 11:39 AM

I think it's something specific to a longer save, since fresh start has both 'get_girls' and 'get_girls_hh' take roughly the same amount of time, matching your experience. I also can't really see anything that's changed much since 0.2.

BTW, if this is an issue, do you also get infinite looping errors for start-of-month girl generation?

Otherwise, I can only guess that somehow, your girlpack settings, the existing girls in that particular save, and your requests for the HH combine in a way that it either takes way too long for your toaster to find a girl matching these settings, or to verify that no such girl can be generated. If you can provide me with a save and the non-image contents of your girl packs (directory structure, _BK.ini files and custom scripts), and preferably also the specifics for the HH request, I can try looking into what exactly is causing the issue. No promises, though.

What you can try as a desperate, toaster-special option is to increase the engine-allowed loop timer. I think this is the most relevant part of the discussion on that topic I had with mistercb a little while ago.

Jman · Dec 06, 2024, 07:29 PM

Alright, new version up. I tried to reduce girl generation time, but this whole scheme is so complex now that I might have easily broken something. Well, I certainly did break some things, and I fixed what I found, but that was nowhere even near comprehensive testing.

So, I'd appreciate some feedback, both on general bugginess and whether the loops are getting faster or not.

D4EH · Dec 07, 2024, 04:42 AM

I've been testing and it seems the newer version is crashing/giving way more errors for me than the previous one, i tried changing the;

Code Select

    if not renpy.config.developer:
        delay *= 200

But this didn't help either, so i tried deleting other mods i had, and got rid of fixations mod and crisJobmod Bonanza edition from you, no changes either.

I tested on my previous save, new save, now it's crashing even the first time you use the HH which was already fixed by you, i tried going back to the previous version, and while HH does work fine on a new save, i noticed it does crash when trying to reroll girls, even if i dont "spam" click.

I dont think i have any girl with a bk.ini that may be messing with generation, but here's a list of my girlpacks just in case

Spoiler

QuoteName Format Size Path
------------------------------------------------------------------------------------------------------------
girls DIR 10.254 GB C:\Games\F95\Brothel_King-pc\game\girls
Acheron DIR 153.702 MB C:\Games\F95\Brothel_King-pc\game\girls\Acheron
Alcina Dimitrescu DIR 358.831 MB C:\Games\F95\Brothel_King-pc\game\girls\Alcina Dimitrescu
Aragaki Ayase DIR 55.178 MB C:\Games\F95\Brothel_King-pc\game\girls\Aragaki Ayase
Artoria Pendragon DIR 225.247 MB C:\Games\F95\Brothel_King-pc\game\girls\Artoria Pendragon
Asuna DIR 152.769 MB C:\Games\F95\Brothel_King-pc\game\girls\Asuna
Erza Scarlet DIR 698.176 MB C:\Games\F95\Brothel_King-pc\game\girls\Erza Scarlet
Fern DIR 67.717 MB C:\Games\F95\Brothel_King-pc\game\girls\Fern
Fiona Frost DIR 165.990 MB C:\Games\F95\Brothel_King-pc\game\girls\Fiona Frost
Frieren DIR 81.412 MB C:\Games\F95\Brothel_King-pc\game\girls\Frieren
Furina DIR 114.846 MB C:\Games\F95\Brothel_King-pc\game\girls\Furina
Hanako DIR 105.607 MB C:\Games\F95\Brothel_King-pc\game\girls\Hanako
Hasumi DIR 83.657 MB C:\Games\F95\Brothel_King-pc\game\girls\Hasumi
Hinata Hyuga DIR 287.202 MB C:\Games\F95\Brothel_King-pc\game\girls\Hinata Hyuga
Honoka DIR 385.412 MB C:\Games\F95\Brothel_King-pc\game\girls\Honoka
Ichika DIR 62.431 MB C:\Games\F95\Brothel_King-pc\game\girls\Ichika
Ino Yamanaka DIR 221.525 MB C:\Games\F95\Brothel_King-pc\game\girls\Ino Yamanaka
Jane DIR 66.781 MB C:\Games\F95\Brothel_King-pc\game\girls\Jane
Kafka DIR 296.662 MB C:\Games\F95\Brothel_King-pc\game\girls\Kafka
Karin DIR 150.607 MB C:\Games\F95\Brothel_King-pc\game\girls\Karin
Kasumi DIR 243.858 MB C:\Games\F95\Brothel_King-pc\game\girls\Kasumi
Kayoko DIR 56.016 MB C:\Games\F95\Brothel_King-pc\game\girls\Kayoko
Kazusa DIR 72.092 MB C:\Games\F95\Brothel_King-pc\game\girls\Kazusa
Kousaka Kirino DIR 67.952 MB C:\Games\F95\Brothel_King-pc\game\girls\Kousaka Kirino
Lian Xin DIR 44.653 MB C:\Games\F95\Brothel_King-pc\game\girls\Lian Xin
Marie Rose DIR 269.527 MB C:\Games\F95\Brothel_King-pc\game\girls\Marie Rose
Mash Kyrielight DIR 166.705 MB C:\Games\F95\Brothel_King-pc\game\girls\Mash Kyrielight
Matou Sakura DIR 201.811 MB C:\Games\F95\Brothel_King-pc\game\girls\Matou Sakura
Momiji DIR 187.135 MB C:\Games\F95\Brothel_King-pc\game\girls\Momiji
Nessa DIR 386.955 MB C:\Games\F95\Brothel_King-pc\game\girls\Nessa
animations DIR 279.786 MB C:\Games\F95\Brothel_King-pc\game\girls\Nessa\animations
Noa DIR 76.927 MB C:\Games\F95\Brothel_King-pc\game\girls\Noa
Nonomi DIR 101.367 MB C:\Games\F95\Brothel_King-pc\game\girls\Nonomi
Nyotengu DIR 215.542 MB C:\Games\F95\Brothel_King-pc\game\girls\Nyotengu
Olga Discordia DIR 48.882 MB C:\Games\F95\Brothel_King-pc\game\girls\Olga Discordia
Orihime Inoue DIR 239.545 MB C:\Games\F95\Brothel_King-pc\game\girls\Orihime Inoue
Panam Palmer DIR 407.975 MB C:\Games\F95\Brothel_King-pc\game\girls\Panam Palmer
Raven DIR 113.965 MB C:\Games\F95\Brothel_King-pc\game\girls\Raven
Rebecca DIR 321.102 MB C:\Games\F95\Brothel_King-pc\game\girls\Rebecca
Rem DIR 545.371 MB C:\Games\F95\Brothel_King-pc\game\girls\Rem
Rio DIR 100.291 MB C:\Games\F95\Brothel_King-pc\game\girls\Rio
Riruka DIR 53.149 MB C:\Games\F95\Brothel_King-pc\game\girls\Riruka
Sadako Yamamura DIR 306.852 MB C:\Games\F95\Brothel_King-pc\game\girls\Sadako Yamamura
Sakura Haruno DIR 345.497 MB C:\Games\F95\Brothel_King-pc\game\girls\Sakura Haruno
Shiroko DIR 82.407 MB C:\Games\F95\Brothel_King-pc\game\girls\Shiroko
Shogun Raiden DIR 148.062 MB C:\Games\F95\Brothel_King-pc\game\girls\Shogun Raiden
Sparkle DIR 239.453 MB C:\Games\F95\Brothel_King-pc\game\girls\Sparkle
Tier Harribel DIR 107.543 MB C:\Games\F95\Brothel_King-pc\game\girls\Tier Harribel
Tohsaka Rin DIR 217.463 MB C:\Games\F95\Brothel_King-pc\game\girls\Tohsaka Rin
Toki DIR 107.839 MB C:\Games\F95\Brothel_King-pc\game\girls\Toki
Tsunade Senju DIR 188.945 MB C:\Games\F95\Brothel_King-pc\game\girls\Tsunade Senju
Ubel DIR 73.006 MB C:\Games\F95\Brothel_King-pc\game\girls\Ubel
Unohana Retsu DIR 199.532 MB C:\Games\F95\Brothel_King-pc\game\girls\Unohana Retsu
Yinlin DIR 94.285 MB C:\Games\F95\Brothel_King-pc\game\girls\Yinlin
Yor Forger DIR 329.255 MB C:\Games\F95\Brothel_King-pc\game\girls\Yor Forger
Zoe (League of legends) DIR 405.122 MB C:\Games\F95\Brothel_King-pc\game\girls\Zoe (League of legends)
------------------------------------------------------------------------------------------------------------
56 Files - 10.254 GB

[close]

Here's a list of errors i got while testing the latest version 218 and the previous one, 217

Spoiler

Code Select

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1984, in script call
    call make_hhgirl(making_name = new_path)
  File "game/Mods/Headhunter/Headhunter.rpy", line 2573, in script
    label make_hhgirl(making_name):
Exception: Possible infinite loop.

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1984, in script call
    call make_hhgirl(making_name = new_path)
  File "game/Mods/Headhunter/Headhunter.rpy", line 2577, in script
    if headhunted_rank != int(headhunted_rank):
Exception: Possible infinite loop.

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1984, in script call
    call make_hhgirl(making_name = new_path)
  File "game/Mods/Headhunter/Headhunter.rpy", line 2606, in script
    $ hhgirl.set_name()
Exception: Possible infinite loop.

previous version (217):

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1965, in script call
    call make_hhgirl(making_name = get_real_girlpath(hhgirl.path))
  File "game/Mods/Headhunter/Headhunter.rpy", line 2554, in script
    while len(g_list) < 1 and attempts < 100:
Exception: Possible infinite loop.

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1965, in script call
    call make_hhgirl(making_name = get_real_girlpath(hhgirl.path))
  File "game/Mods/Headhunter/Headhunter.rpy", line 2540, in script
    label make_hhgirl(making_name):
Exception: Possible infinite loop.

[close]

Im running out of ideas, i thought of deleting all the bk.ini files from the girlpacks, but that wouldn't do much besides getting rid of original girls, so i refrained from doing it, but im open for any suggestion.

Edit: I dont use girl mixes, i haven't edited any bk.ini file for the girls above, here's a file that includes all the folders and the bk.ini of the girls https://pixeldrain.com/u/xvb7k4sE, there's no events based from what i saw, only 33 out of 55 girls i have have bk.ini files too

Jman · Dec 07, 2024, 05:17 AM

Can you also upload a save? I presume no matter what you order, loops are still happening?

What if you go into the HH file and replace all the 'attempts < 100' parts with something like 'attempts < 10' or 'attempts < 3'?

Edit1: I'm kind of at a loss here, because for me HH girl generation times are down an order of magnitude, and even if I tweak the 'delay *= ' part to low enough that I almost can't start the game anymore, HH still generates fine without loop errors. I'm not sure how you can be getting timeout errors worse than before.

Edit2: What if you increase the 'delay *=' value to something ridiculous like 10000?

D4EH · Dec 07, 2024, 05:41 AM

Changed Delay value to 20000, started a new save, went to HH, picked stats, charm 5, got these errors, tried rolling back a couple times to see how much it varied, but it went back to previous errors, then decided to roll back, leave charm at 0 so it's completely random, and it did generate a girl, though the time i attempted to reroll it i got an error, and rolling back this time crashed the game, here's the newly created save i used to test this https://pixeldrain.com/u/L4GxcGkZ

Here's the errors

Spoiler

Code Select

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1982, in script
    while hhgirl.original and attempts < 100:
Exception: Possible infinite loop.

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1982, in script
    while hhgirl.original and attempts < 100:
  File "C:\Games\F95\Brothel_King-pc\renpy\execution.py", line 61, in check_infinite_loop
    raise Exception("Possible infinite loop.")
Exception: Possible infinite loop.


After leaving the charm value at 0:

While running game code:
  File "game/Mods/Headhunter/Headhunter.rpy", line 1984, in script call
    call make_hhgirl(making_name = new_path)
  File "game/Mods/Headhunter/Headhunter.rpy", line 2573, in script
    label make_hhgirl(making_name):
Exception: Possible infinite loop.

[close]

Edit: (old versions, with bugs but all options available from the start) of 0.3 works, i can even spam click and no matter what i do it wont crash, though it seems it struggles trying to find the girls, like 1 out of every 3 or 5 has the traits and stats you specified, I dont know if this is any helpful but hey, any lead is good when there's an issue as weird as this one.

Edit 2: Changed the attempts value to 10 and it kinda works? At least the first time, and it did it fast, but rerolling girl still crashes, imma try again and do it multiple times to see if it was a one time thing, and if it wasn't imma try with 3 instead of 10

Edit 3: Reducing the number 10 didn't cause a placebo effect, it actually affected generation positively, and i can choose a stat and the girl generates accordingly, and does it fast, for instance this time i picked sensitivity 5 and searched for a girl, tried to reroll and it did it fast, only way i was able to get an error was by clicking fast, but i already taked that for granted, im going to try now while reducing the value to 5

Jman · Dec 07, 2024, 07:10 AM

New version!

Okay, there was an actual infinite loop in there, caused by careless reuse of variable names.

See if it works now.

I couldn't get it to trigger too often, though, so if you're getting infinite loop errors consistently, there might be something else amiss.

Also, I (hope I) fixed support for girls to mixes who don't actually live in the same directory ('virtual mix girls').

Changing the loops to 10 or 5 instead of 100 might be prudent on a slower machine anyway. You might get some girl gen errors that way, mostly originals that are not supposed to be originals). A good/large set of girl packs should cut down on those. Increasing the delay value some is probably a better solution than reducing these to nothing. A little wait in-game is better than wrong girl or no girl.

I'm not sure I can do much about the 'clicking too fast' issue. If the game is thinking, it doesn't like getting clicked I guess.

D4EH · Dec 07, 2024, 11:51 AM

Seems to be working fine now, no more infinite loops, doesn't even throw error if i click too fast, nice.
I tested for a bit, and it seems HH is incapable of getting random girls now tho, only originals, or originals that are not supposed to be originals like you said, I don't mind, but im sure that's a bug lol

Edit: Generation Accuracy seems to be reduced too (Girls that dont have the stat you're looking for) But i cant tell if this is a bug or a feature since im testing this on a new game

Edit 2: Seems you changed 'attempts < 100' to 'attempts_original < 100' and attempts_match' or others i may have missed, does changing the value still produce the same effect? I havent checked

Also in case you dont have the bug where only original girls are generated, do you think that me having no specific girl mixes (All girls on #default) may have affected generation? Should i use girl mixes?

Jman · Dec 07, 2024, 12:17 PM

Edit2: New version! /edit2

If reducing the various 'attempts' values worked for you before, it should continue working.

Not sure how you're getting originals that are not supposed to be originals. Can you give me a save and a HH order with all details that results in this? If it's a matter of too short loops, fine, but you seem to be getting those even with the values at 100? I'm asking, because the few tests I've done have come back nicely, originals and non-originals exactly as expected, non-originals replacing originals, etc. And most of the time, I'm not even entering any loops at all, so our situations should be comparable. It must be again some corner case that I'm not able to figure out, and detailed instructions for repeating that situation are what I need.

What kind of stats are you not getting? If a stat value fluctuates some, that's fine, vanilla BK randomises stats a lot. If it's a missing trait and you didn't specify more traits than allowed (2 positive, 1 negative and maybe 1 gold), now that'd be a problem.

Girl mixes should only be making the situation worse, if anything.

Edit1&2: Actually, what seems to be going on is that some girl packs have declared 'keep_traits' and 'keep_skills' as definitely 'false', and HH inherits that.

Should be fixed now.

No idea what's going on with originality mismatches, except for too short loops. But I rarely get loops myself, so I'd appreciate an example. Perhaps there's again some .ini setting that I'm forgetting about, or some configuration of settings and existing girls, or something. So I'd again need a save and detailed instructions.

D4EH · Dec 07, 2024, 03:33 PM

Here's a save just in the middle of generation https://pixeldrain.com/u/JQQUyfHe, didn't do anything in specific, just created a new game, went to the slave market, went to the HH, picked a random stat to test, this time charm for instance, HH found a girl, girl has the name of a original, but doesn't follow anything from the BK.ini, not that I care much right, but that's weird, they i noticed that no girl with random names were generating, so only fake original girls ever come out lol

Edit: Imma create a new save and check if this still happens on your newest version

Jman · Dec 07, 2024, 04:10 PM

Edit: Another new version! \edit

Is the 'original name' an actual yellow original name, or is she just a clone set to be named the same? That is, does she still have a gold trait or not? If not, things are working fine. Your game settings can set every clone to have an original name, for that matter.

Edit: I think I see the problem with these 'fake original' names. New version should fix that, and also reorder traits in the normal gold-positive-negative order instead of the sometimes jumbled mess.

I really appreciate the bug-hunting you've been doing here.

D4EH · Dec 08, 2024, 05:26 AM

Im getting random girls again, and generation seems to be working flawlessly, I'll keep bug-hunting, but so far this seems to be the best version you've put out that i tried, couldn't even get a crash even when trying to get the game to crash in purpose, thanks for your work, I'll now add back CJMT mod and try playing a game to see if anything weird happens

vadi92 · Dec 08, 2024, 07:35 PM

Quote from: Jman on Dec 07, 2024, 04:10 PMI really appreciate the bug-hunting you've been doing here.

You didn't said that to me when we worked on your bonanza mod

Even when i sent you bug reports pretty much in every 15~20 minutes. (Tried to break your mod in every possible way what i could just think of).

Edit: Even if you have forgotten about it. I have a pretty good memory of things so you cant argue with me regarding this

Like the one when we tried to help out a spanish guy with broken english so he could play the vanilla game. (Took us about a week to make him understand what are we tried to tell him until i made a simple pic guide for him as a last result.)

Jman · Dec 08, 2024, 07:54 PM

Actually, I do have half-forgotten it and I'm still amazed to this day that Bonanza was even vaguely compatible with 0.2. I certainly can't see how it'd be fully compatible without someone pouring months of work into it.

I guess some of that lack of overt appreciation stems from the fact that said Bastard Bonanza was only useful to you, and all the appreciation went into helping you.

Or if you mean old Bonanza, then most of my brainpower went into discussing the minutiae on the forum and actually fixing the issues found. I'm grateful to everyone who contributed to the old Bonanza thread, may it rest in peace.

But I do value you as one of the few still active members of the 'old guard', and helping people as much or more than I do.

All that said, I'd appreciate it even more if you tried to break this version of HH.

Edit: I don't remember the spanish guy, but I do remember there was one fellow who kept breaking and discussing Bonanza to the last, including writing his own function timer tests. I really wish I could recall his moniker, but alas...

vadi92 · Dec 08, 2024, 08:12 PM

Quote from: Jman on Dec 08, 2024, 07:54 PMI guess some of that lack of overt appreciation stems from the fact that said Bastard Bonanza was only useful to you, and all the appreciation went into helping you.

It wasn't a request from me but from a few people from the HHS forum and from F95. They always asked it if your Bonanza mod was compatible with the 0.2 version.

And no i didn't helped you in the 0.15 version as i was started playing with BK when it's first came out as a 0.2 version.

Quote from: Jman on Dec 08, 2024, 07:54 PMEdit: I don't remember the spanish guy

I am not surprised about this. As you pretty much cut all ties with the F95 forum.

News:

[Resources] Headhunter mod