Well, the activation/deactivation labels just aren't run consistently. Sometimes I can go to another screen and then return to the main screen to get them to work, other times they just flat don't run. I do get the 'activated' notification, though.

Starting a game with the mod enabled seems OK.

Didn't really test too hard.

Oh, yeah, what's definitely bad and easy to find is this:

  File "game/BKmain.rpy", line 878, in script
    $ update_list = game.update_mods()
  File "game/BKmain.rpy", line 878, in <module>
    $ update_list = game.update_mods()
  File "game/BKclasses.rpy", line 205, in update_mods
    for mod in self.active_mods.values():
RuntimeError: dictionary changed size during iteration


Thanks for porting this.

With the new 0.3 version your wall of text makes imposible to reach the deactivate mod button.





and gives this error on mod start:

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 91, in script
    python:
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 234, in <module>
    brothel.rooms[room].update_cust_limit(True)
NameError: name 'brothel' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 91, in script
    python:
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.3t\Brothel_King-pc\renpy\ast.py", line 823, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.3t\Brothel_King-pc\renpy\python.py", line 1178, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 234, in <module>
    brothel.rooms[room].update_cust_limit(True)
NameError: name 'brothel' is not defined

Windows-10-10.0.19045 AMD64
Ren'Py 8.2.0.24012702
Bro King 0.3t v240825
Mon Aug 26 05:35:42 2024


Quote from: DarkFire on Aug 26, 2024, 03:37 AMWith the new 0.3 version your wall of text makes imposible to reach the deactivate mod button.





and gives this error on mod start:

Code Select Expand

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 91, in script
    python:
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 234, in <module>
    brothel.rooms[room].update_cust_limit(True)
NameError: name 'brothel' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 91, in script
    python:
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.3t\Brothel_King-pc\renpy\ast.py", line 823, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.3t\Brothel_King-pc\renpy\python.py", line 1178, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 234, in <module>
    brothel.rooms[room].update_cust_limit(True)
NameError: name 'brothel' is not defined

Windows-10-10.0.19045 AMD64
Ren'Py 8.2.0.24012702
Bro King 0.3t v240825
Mon Aug 26 05:35:42 2024


Yes, I just entered the game and found this problem. The button for [enable/disable] MOD is outside the screen and there is no way to view and click it.
I hope the master can fix this bug.

Updated.

While it seems the room capacity update wasn't strictly necessary, I hope Goldo restores the ability for mod init labels to directly alter brothel attributes (and most other game init things). Working around this is not too hard, but will certainly discourage new modders.

Shortened the wall of text, so you can actually use the mod. I'd like a viewport for the text, if Goldo insists on being so wasteful with spacing.

The mod tries to make the working check even when deactivated:

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/BKmain.rpy", line 1180, in script
    $ girl.set_job(r)
  File "game/BKmain.rpy", line 1180, in <module>
    $ girl.set_job(r)
  File "game/BKgirlclass.rpy", line 1847, in set_job
    if self.will_do(job):
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 22, in will_do_new
    if self.get_stat("obedience") + self.get_stat("charm") >= (waitress_test / cheat_modifier["stats"]):
NameError: name 'waitress_test' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/BKmain.rpy", line 1180, in script
    $ girl.set_job(r)
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.3t\Brothel_King-pc\renpy\ast.py", line 823, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Users\Dani\Desktop\Juegos\Brothel_King-0.3t\Brothel_King-pc\renpy\python.py", line 1178, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/BKmain.rpy", line 1180, in <module>
    $ girl.set_job(r)
  File "game/BKgirlclass.rpy", line 1847, in set_job
    if self.will_do(job):
  File "game/Mods/ChrisJobMod/ChrisJobMod.rpy", line 22, in will_do_new
    if self.get_stat("obedience") + self.get_stat("charm") >= (waitress_test / cheat_modifier["stats"]):
NameError: name 'waitress_test' is not defined

Windows-10-10.0.19045 AMD64
Ren'Py 8.2.0.24012702
Bro King 0.3t v240827
Tue Aug 27 03:08:50 2024


Fixed, I hope. The cause was also a kinda stupid move of mine.



I'd still like a viewport for the description, or at least less extravagant white space in the mods screen.



Edit: Button moved instead of viewport, more text space added, the wall of text is back in the mod!

Quote from: Jman on Aug 27, 2024, 02:28 AMFixed, I hope. The cause was also a kinda stupid move of mine.



I'd still like a viewport for the description, or at least less extravagant white space in the mods screen.



Edit: Button moved instead of viewport, more text space added, the wall of text is back in the mod!

A viewport doesn't work there, for reasons that elude me.

Perhaps not where you tried to put it, but something like this would work okay for the description, which is the actual problem:
                        text ""
                        viewport xfill True:
                            mousewheel True
                            draggable False
                            scrollbars None
                           
                            vbox xsize xres(450):
                                text selected_mod.description size res_font(14) color c_brown

                        text ""

                hbox xsize xres(200):
                    if selected_mod.active:
                        textbutton "Deactivate Mod" action renpy.curried_invoke_in_new_context(selected_mod.deactivate)
                    else:
                        textbutton "Activate Mod" action renpy.curried_invoke_in_new_context(selected_mod.activate)

                        # textbutton "Reset Mod" action renpy.curried_invoke_in_new_context(reset_mod, selected_mod)


Fixed to be compatible with the new 0.3t.

Still can't get the mod to disable without manually calling the 'deactivate' label. Tried both the mods menu and going to the '?' button.

Would appreciate Goldo looking into this. To test, get a fresh girl with bad stats and try to make her a waitress. CJMT will complain, vanilla will not.

 "There is a sort of tier structure where waitress/service are at the bottom and geisha/fetish are at the top." is a bit hard for me to understand. , maybe because of the translation problem.
Mr. Jman, could you please explain the meaning of this passage to me again using the simplest possible words?
I really need and appreciate your detailed answer, love you! （づ￣3￣)づ╭❤~

Waitress easy job (performance bonus, least tiring), money bad.

Geisha hard job (performance malus), money good.

Dancer in-between, serves lots of customers at once to boost whoring, tiring.

Masseuse in-between, serves few customers, money per customer best, somewhat tiring.

Silk threads of knowledge, you've woven so true,
Tying East to West, in understanding anew;
For your patience, a dragonfly's dance I do,
A graceful thanks, across the digital blue.

If you start the game with this mod without skipping intro, you may get stuck on the tutorial screen for choosing job for girls. Since the girl refused to perform the job, you can't continue.
Can be solved by just skipping intro though, but could be a problem for those who didn't.